varnish-cache icon indicating copy to clipboard operation
varnish-cache copied to clipboard

vmod_blob: Add convenience functions for urldecode and urlencode

Open nigoroll opened this issue 1 year ago • 3 comments

For the common cases, the generic and versatile syntax is really cumbersome.

Why exactly did we not add these earlier?

nigoroll avatar Jan 15 '25 18:01 nigoroll

Could it be worth writing somewhere that blob.urldecode might be unsafe and truncate values if the url contains %00? (if thats the case)

simonvik avatar Jan 15 '25 19:01 simonvik

@simonvik good point. Are there any established alternatives to handling %00 like throwing an error? If yes, I think we should rather review any IDENTITY encoding to STRING.

nigoroll avatar Jan 16 '25 09:01 nigoroll

This triggered #4255

nigoroll avatar Jan 16 '25 09:01 nigoroll