bitfield parameter behavior appears inconsistent

[nigoroll]

Expected Behavior

Using none and all should work consistently, or a good reason why not should be apparent.

Current Behavior

Using none works for feature, but not for vsl_mask. Conversely, all works for vsl_mask, but not for feature.

(cli)

varnish> param.set feature none
200        

varnish> param.set vsl_mask none
106        
Missing '+' or '-' (none)

(attempting to set param 'vsl_mask' to 'none')
varnish> param.set vsl_mask all
200        

varnish> param.set feature all
106        
Missing '+' or '-' (all)

(attempting to set param 'feature' to 'all')

Possible Solution

No response

Steps to Reproduce (for bugs)

No response

Context

Noticed while reviewing release docs

Varnish Cache version

No response

Operating system

No response

Source of binary packages used (if any)

No response

[dridi]

That's a problem created by the nature of bits parameters. Are they additive by default? They support "none" and otherwise "all".

[nigoroll]

But is that not just the way we print the value? If yes, why would it impact the availability of "none" and "all" for param.set?

[nigoroll]

bugwash @Dridi said he might want to send a PR

[dridi]

I believe this was fixed in #4258, feel free to reopen if something was not addressed.