Viktor Varland

Results 79 comments of Viktor Varland

https://github.com/dhis2/prop-types/pull/133

If need be it can be changed; it was never formally decided on in the frontend forum, so it is fair game as I see it. To do so we...

The code organization hierarchy that works for a 1K LoC application may not scale to a 10K LoC application, which in turn may not scale to a 100K LoC application....

Storybook makes a lot of sense from a development (automated testing is included in the term) perspective, where it is easy to build a component, and its features in isolation...

> > @Mohammer5: We're using one of the newer storybook version which supports mdx. We could use the storybook with mdx and it's folder mechanism. > > @ismay: I think...

> @varl I see. I don't have any strong preferences either. I ran into issues with storybook, but I can't say it's much more than me being slightly annoyed with...

Thanks for the links here, @amcgee. I see that I have missed and/or forgotten about a lot of prior context. For example, I forgot that MDX is standalone and not...

Quick note: If we are pulling in an external library that would put the color-picker in **ui-widgets**.

This is about a library, not an App. I think that's important to remember. All browsers today zoom the entire page, they no longer just increase the font-size and cause...

> > Other than that, I think that px is a sane default for a component library. > > Weren't we were kind of decided on using `rem` and `em`...