klogg icon indicating copy to clipboard operation
klogg copied to clipboard

[Highlighters]: forbid to save blank patterns or count them as "nothing" instead of "everything"

Open PetbkA opened this issue 2 years ago • 1 comments

OS: Windows 10 version 22H2 x64 App Version: 23.07.0.1541 x64 Qt6

Steps to reproduce:

  1. Open Highlighters → Configure highlighters...;
  2. Create new highlighter with empty Matching Pattern and set e.g. pink background color for it;
  3. Activate highlighter set with such highlighter - NOK, all lines are being highlighted with color from step 2 'cause empty pattern is being counted as "everything".

I suggest to either forbid changing highlighter in editor until its pattern will not be empty or count empty patterns as "nothing" instead of "everything"

PetbkA avatar Jul 29 '23 13:07 PetbkA

Indeed empty pattern should mean "nothing" in this case

variar avatar Nov 18 '24 23:11 variar