klogg icon indicating copy to clipboard operation
klogg copied to clipboard

[feature request] Add a button in the search tab to keep current search and show a new search results in a new tab

Open Abay11 opened this issue 2 years ago • 6 comments

I would like to suggest this feature, something like this you could see in the VS IDE: image.

Abay11 avatar May 28 '23 08:05 Abay11

I've merged the PR. However, there was one crash that could be related. I made two tabs. The removed the active one, then tried to search for something new without creating new tab. I was unable to reproduce it, unfortunately. I'm going to release a new CI build and watch crash reports from Sentry to find something related.

variar avatar Jun 25 '23 21:06 variar

Can be tested in 23.06.0.1479+

variar avatar Jul 01 '23 10:07 variar

Very useful feature! One small suggestion: When user switch to a another search result tab, klogg could auto change the contents in the search bar. So user can continue to search on the origin base. And the search content is no need to show on the tab title, which may be too long.

xaljer avatar Jul 01 '23 11:07 xaljer

I am considering it, but I am not sure. Automatically changing the search expression might ruin the complex regex that user created and then by accident switched to another tab

variar avatar Jul 01 '23 11:07 variar

I am considering it, but I am not sure. Automatically changing the search expression might ruin the complex regex that user created and then by accident switched to another tab

Why user's regex would be ruined? user's regex must be remembered by a tab, so user can switch back. And all regex should be saved in the history, wouldn't be losted.

xaljer avatar Jul 01 '23 13:07 xaljer

Search history is saved when user actually does a search. Switching between tabs case could work if tab remembers current input in regex textbox.

variar avatar Jul 01 '23 15:07 variar