Highlight matches don't work in logical combining mode

[xaljer]

Also no right on pattern like aaa.*(bbb|ccc), highlight matches only show bbb and ccc.

[variar]

That is known limitation of highlighters engine. It uses Qt regular expressions, and not the full Hyperscan+exprtk thing. The reason for this is that Hyperscan by default does not provide start of match offset, and does not provide matches capture groups.

As for expressions like aaa.*(bbb|ccc) -- there is a capture group there, so klogg assumes, that user wants to see only captured part highlighted. For regular highlighters that should be configurable, and for match highlights -- capture groups should be ingored.

[variar]

Moved capture group highlight issues to #373

[reflekteur]

I thought this was the intended behavior, no? 👀

If you need to use capture groups but want to highlight the whole match, simply wrap the whole match in another capture group c: Like this: (aaa.*(bbb|ccc))

[variar]

The behaviour for capture groups is intended, but sometimes they are used just to group alternatives for | operation. Wrapping the whole expression with another set of parentheses is a clever trick, but an option to disable groups highlight (#373) can be more intuitive.