klogg icon indicating copy to clipboard operation
klogg copied to clipboard

Feature request: enhance the quick find

Open xaljer opened this issue 4 years ago • 11 comments

Some ideas:

  • [ ] add menu to add select word to quick find like "add to search".
  • [x] auto add escape character for special characters when add to quick find.
  • [x] support custom key binding for find next and find previous (and even more operations). Currently, user need double click to select a word and use shift + * or find option in menu to start quick find. This is not so "quick". I think a single click (right hand) + a single key (left hand) is much easier.
  • [ ] add search history to quick find.
  • [ ] support Hyperscan for quick find.
  • [ ] show total find count and current number in total.
  • [x] add shotcuts to jump next/previous match item.

xaljer avatar May 29 '21 04:05 xaljer

Thanks for ideas!

CTRL-F shortcut should replace quick find search pattern with currently selected text.

/ and * shortcuts are intended for full-size keyboards with separate numpad. That way there is no need to press shift. For smaller keyboards there are , and . shortcuts that do the same thing (quick find backward and forward).

variar avatar May 29 '21 17:05 variar

Thanks for the reply, I didn't know the , and .. Since Klogg is mainly for viewing, only some window can accept input, lots of single key can be used as shortcut. That's Vim how to optimize shortcuts. User defined shortcut will be more convenient and powerful. User may prefer using X or XX or ctrl+X or alt+X or space+X...

xaljer avatar May 30 '21 04:05 xaljer

A dialog to edit custom key bindings will be added in one of next builds. Not all shortcuts have been refactored to this new scheme. More will come next week.

variar avatar May 30 '21 16:05 variar

General issue for hotkeys customization #26

variar avatar May 30 '21 16:05 variar

@variar hi, would you like to implement this "auto add escape character for special characters when add to quick find." on 2021.09? It's useful and should be easy to add?

xaljer avatar Aug 07 '21 04:08 xaljer

That was not that easy to hack, but seems to work. Quickfind implementation inherited from glogg is quite a mess.

variar avatar Aug 07 '21 13:08 variar

Thank you very much.

xaljer avatar Aug 08 '21 02:08 xaljer

Is there a way to restrict quickfind to marked/matched lines only? If not, I think this feature would make quickfind a much more versatile tool.

janafrank avatar Aug 26 '21 01:08 janafrank

Quickfind should work in the bottom view which shows marked/matched lines if that view was in focus.

variar avatar Aug 26 '21 04:08 variar

22.06.0.1289 x64 - I'll add some here:

  1. Allow disabling "search as you type" behavior. I'm searching through pretty big logs with sometimes pretty lengthy lines. Usually the steps are:

    1. Find error in some script through main search and select the line from results;
    2. Find script entry point. For this I'm using Quick Find - due to "search as you type" I have to first find the entry point of the next script and then use Shift+F3 to Quick Find backward. This all is complicated by slowness of the whole process (due to size of logs, I guess).

    If I could disable "search as you type", I would just type keywork and use Quick Find backward;

  2. What should Quick Find forward and Quick Find backward actions do? Assigning hotkeys to them seems to do nothing, meanwhile there's Main View: find next and Main View: find previos hotkeys which do the same

PetbkA avatar Dec 27 '22 14:12 PetbkA

22.06.0.1289 x64 - I'll add some here:

  1. Allow disabling "search as you type" behavior

There is a setting to turn off incremental quick find in the General tab. image

  1. What should Quick Find forward and Quick Find backward actions do? Assigning hotkeys to them seems to do nothing, meanwhile there's Main View: find next and Main View: find previos hotkeys which do the same

When some text is selected these should open quick find panel and add the text there, ready to do the search

variar avatar Jan 14 '23 19:01 variar