The file status icon on tabs is not clear

[wiz0u]

I don't understand the behavior of that little fellow icon after the file name in the tab header. Some times it's ≡, sometimes it's an "eject down" icon that looks like the one from the "follow file" button, sometimes this "eject down" icon is red.

However I haven't found any link with the actual "follow mode" of the file, or even as an indicator that there as been new lines added since I last viewed this tab..

I don't know if it's buggy or just an explanation is required. BTW, the 'Wiki' link on top of this github repo doesn't seem to work.

[wiz0u]

My recommendation would be: ≡ when the file is not in follow mode red ≡ when the file is not in follow mode, is not the active pane, and new data has been detected 'eject down' when the file is in follow mode 'eject down red' when the file is in follow mode, is not the active pane, and new data has been detected

[Mte90]

My question is more simple, what is the purpose of that option? There is already the filesystem change monitoring option. Maybe it is for the auto scrolling?

[variar]

It is supposed to work like this:

• ≡ if user has interacted with the widow when tab was active (mouse clicks, hotkeys or scrolling) so there is no new data for user
• "eject" if tab was inactive and file changed on disk and was reloaded
• "red eject" if tab was inactive and search was set to auto-refresh and new search results appeared

[wiz0u]

Oh so 'red' is related to new search results? that seemed not intuitive to me...

Red seems like a highlight to me, meaning there is something new (new lines, not necessarily search-related).

Maybe it would work better with different kinds of highlights... For example 'blue eject' for new lines, and 'red eject' for new lines matching the auto-refresh search.

That would be more intuitive to me.

Also I was confused by the 'eject' icon because it looked very much like the 'Follow file' icon (but you changed the Follow file recently so...)

[variar]

Made this icon to be 'blue eject' for new lines, and 'red eject' for new lines matching the auto-refresh search from build 483

[wiz0u]

thanks, i will check that

[wiz0u]

The blue/red eject should disappear once the tab is activated, as an acknowledgement that the user has seen this notification icon.

If the file is already the active tab, there should be a way to reset this "new lines" status icon aswell, otherwise the 'eject' icon will stay forever. Maybe on any action (click, wheel, keyboard) in the window ?

[variar]

Eject icon should already disappear on scrolling and some mouse clicks (maybe inside the window with search results). I think the original Nick's idea behind it was to remove the icon once user scrolled to new data, but I'm not sure.

I'll try to add more user interaction events to remove it and see how it goes.

[wiz0u]

It disappear on scrolling, right.

Then please make it disappear also when the user switch to that tab (and the view is already at the end - because of follow mode)

[wiz0u]

As far as I can observe, that tab indicator is still not satisfying to me...

I want to be able to see at a glance in which tabs there are new lines. Tab indicator without new lines should be uncolored ≡ as to not attract the eyes. And when I click on a tab with new lines, and go to the end (or follow-mode is active and it is already at the end) the indicator should reset immediately to uncolored ≡. As for the current tab, if there are new lines and follow-mode is active, as soon as klogg window is focused, the indicator should also reset immediately to uncolored ≡.

[variar]

Made icon switch to ≡ when entering tab with changes and follow mode is enabled in 19.12.0.554.

[wiz0u]

That's a good first step. Thanks!

[wiz0u]

Made icon switch to ≡ when entering tab with changes and follow mode is enabled in 19.12.0.554.

Mmh does not always work, it seems.. I have a follow-mode tab that refuse to reset to ≡. Even when I force a scroll down with the mouse.

[wiz0u]

and apparently, the icon does not always turn to blue arrow when there is new lines either.. Not reliable indicator :-(

[ghost]

I noticed another issue which might be related, when tabs are rearranged (via DND) the indicator displays on the tab matching the index where the file was originally, not where it is now. If this is unrelated I can open a separate issue.