varfish-server icon indicating copy to clipboard operation
varfish-server copied to clipboard

frequency filter settings above 5% fail filter

Open stolpeo opened this issue 1 year ago • 2 comments

Describe the bug The frequency filter setting for gnomad exomes/genomes, 1000 genomes and exac make the filter fail (or more precisely nothing happens when the user clicks the filter button) when the settings is above 0.05 (5%).

stolpeo avatar Jan 13 '25 14:01 stolpeo

RCA

The JSON scheme only allows for a range of 0-0.05. This makes the submission fail. In production, the server returns a simple 500 error without stating any reason. The frontend simply does not do anything when the user hits the filter button.

stolpeo avatar Jan 13 '25 14:01 stolpeo

Solution

The current state is obviously more than confusing for the user.

  1. The frontend apparently does not display errors that are caused by the JSON scheme validator and simply fails.
    1. Check if that is true for all JSON scheme validator errors or only this one
    2. Correct that the user gets a proper error message displayed
    3. Decide whether the input check should already happen during input.
  2. Why is there a maximum of 0.05? Could that be extended to accept values from 0-1 (basically the whole possible range)?

stolpeo avatar Jan 13 '25 14:01 stolpeo