react-user-media icon indicating copy to clipboard operation
react-user-media copied to clipboard

return object from hook should be memoized

Open pocesar opened this issue 6 years ago • 2 comments

useMemo on https://github.com/vardius/react-user-media/blob/c5acaae23a804887fdbde8de5ed8cc9cad7e5727/src/useUserMedia.tsx#L53-L56 so you can use the object like:

const media = useUserMedia()

useEffect(() => {
}, [media]) // media is stable, since it's memoized

pocesar avatar Sep 14 '19 21:09 pocesar

Thanks @pocesar, for pointing this out, Do you want to create a pull request ?

vardius avatar Sep 15 '19 01:09 vardius

Why not memoize when necessary? At the upper scope:

const media = React.useMemo(useUserMedia, [])

vardius avatar Apr 26 '20 00:04 vardius