postgres-nio
postgres-nio copied to clipboard
Cleanup: Logging and some more
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
e9b90b2) 62.18% compared to head (cdddfe9) 62.20%.
Additional details and impacted files
@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 62.18% 62.20% +0.02%
==========================================
Files 124 124
Lines 9936 9936
==========================================
+ Hits 6179 6181 +2
+ Misses 3757 3755 -2
| Files | Coverage Δ | |
|---|---|---|
| ...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift | 23.33% <ø> (ø) |
|
| ...urces/PostgresNIO/New/PostgresChannelHandler.swift | 84.77% <100.00%> (ø) |
|
| ...es/PostgresNIO/Utilities/PostgresJSONDecoder.swift | 50.00% <ø> (ø) |
|
| Sources/PostgresNIO/New/PSQLRowStream.swift | 86.33% <0.00%> (ø) |
Related #411.
Logging as well as Errors currently suck in PostgresNIO. I'm allowed to say that, as I was the one who implemented those. We should come up with a better logging and error plan first. Sadly I'm currently extremely low on time. @MahdiBM would you be interested in moving this forward?
@fabianfett sure, but I don't have a plan of myself. How should we proceed?
<code-ql action is broken everywhere for now>