fluent-postgres-driver icon indicating copy to clipboard operation
fluent-postgres-driver copied to clipboard

DatabaseConfigurationFactory improvements

Open ecamacho opened this issue 4 years ago • 4 comments

Improves DatabaseConfigurationFactory:

  • The encoder and decoder parameters are forwarded in the function postgres(url:, maxConnectionsPerEventLoop:, connectionPoolTimeout:, encoder:, decoder:)
  • The encoder and decoder parameters are forwarded in the function postgres(hostname:, port:, username:, password:, database:, tlsConfiguration: , maxConnectionsPerEventLoop:, connectionPoolTimeout:, encoder: , decoder:)

Note: Previously, those parameters were not being forwarded in those two functions, thus the default PostgresDataEncoder and PostgresDataDecoder were being used.

ecamacho avatar Oct 27 '20 09:10 ecamacho

@siemensikkema This is still crashing on the Nightly master Linux versions. Seems like a Swift compiler's regression. The compiler is crashing while trying to compile CNIOBoringSSL from swift-nio-ssl Can we skip those tests?

ecamacho avatar Oct 27 '20 10:10 ecamacho

@ecamacho it seems FluentKit is where it's breaking (fluent-kit/Sources/FluentKit/Enum/EnumBuilder.swift:54:9 - line:65:9) scroll up in the logs and you'll see it. I'm confident it's a swift regression and not something we need to worry about here. I'll discuss with the others what we should do about having these nightly swift versions in the test suite. Could you phrase the title and PR body such that it is ready for release? See https://github.com/vapor/vapor/blob/master/.github/contributing.md

siemensikkema avatar Oct 27 '20 10:10 siemensikkema

@siemensikkema Right, I missed that from the logs. I changed the titles and bodies

ecamacho avatar Oct 27 '20 16:10 ecamacho

@ecamacho I'm just doing some tidy ups and spotted this! If you want to pull in all the latest changes and get it compiling that should fix both the CI and the merge conflicts and we can get this merged. Sorry it's taken so long to get addressed!

0xTim avatar Mar 28 '22 16:03 0xTim

This was fixed at the same time these types were deprecated; those still using the deprecated methods will find they now forward their arguments properly (but should nonetheless switch to the new API).

gwynne avatar May 09 '23 19:05 gwynne