fluent-kit icon indicating copy to clipboard operation
fluent-kit copied to clipboard

Published 20 hours ago • verified publisher icon vapor

Tests failing on trunk

Open nashysolutions opened this issue 2 years ago • 1 comments

Screenshot 2022-06-25 at 06 55 48 Screenshot 2022-06-25 at 06 56 28

Steps to reproduce

  1. Checkout branch main on 2b3ac0556740ea8d68f8616917daf64338d54c1b
  2. Run all tests

Environment

  • M1 chipset
  • macOS 12.3.1
  • swift-driver version: 1.45.2 Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8)
  • Xcode Version 13.3 (13E113)
  • Target platform - macOS

nashysolutions avatar Jun 25 '22 05:06 nashysolutions

It looks like the ordering of parameters in FluentKit is not consistent on macOS - on Linux we seem to have no issues and CI is always fine.

cc @gwynne

0xTim avatar Jun 29 '22 15:06 0xTim

This works in CI because we set SWIFT_DETERMINISTIC_HASHING in the environment; it's just blind luck if it works on Linux without that. At this time, setting the env var is considered a requirement to ensure that tests pass, since fixing it in Fluent proper would introduce performance regressions (due to excess sorting), and working around it in the tests is not always practical.

gwynne avatar Feb 07 '23 11:02 gwynne