docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

Perfect translation

Open CainLuo opened this issue 3 years ago • 13 comments

Improve the untranslated, errors, etc. based on the English version of the document.

CainLuo avatar Jan 16 '22 13:01 CainLuo

Thank you for your translation support. This PR has a lot of content, so it may take some time to check. Please wait patiently.

Jinxiansen avatar Jan 16 '22 15:01 Jinxiansen

@CainLuo Thanks again for helping to translate and sync these documents, it will help a lot of Chinese developers. Also I've added some comments to the PR, if you have free time please check and consider revising. 🍻

Jinxiansen avatar Jan 17 '22 14:01 Jinxiansen

@0xTim Hi Tim I found that the previously merged PR did not trigger the execution of the github action script, so the translated content was not updated to the website, such as this PR: https://github.com/vapor/docs-cn/pull/15/files. Do you know the reason?

Jinxiansen avatar Jan 17 '22 14:01 Jinxiansen

@Jinxiansen looks like the GH action was triggered - https://github.com/vapor/docs-cn/runs/4508150654?check_suite_focus=true. Does it need updating? What's missing?

0xTim avatar Jan 17 '22 15:01 0xTim

@CainLuo Thanks again for helping to translate and sync these documents, it will help a lot of Chinese developers. Also I've added some comments to the PR, if you have free time please check and consider revising. 🍻

@Jinxiansen OK, where do I see your comment? I also found some small details on the problem, is currently being revised one by one, and will submit a PR again after all the changes, please check again then, thank you ~

CainLuo avatar Jan 18 '22 16:01 CainLuo

@CainLuo

Thanks again for helping to translate and sync these documents, it will help a lot of Chinese developers.

Also I've added some comments to the PR, if you have free time please check and consider revising. 🍻

@Jinxiansen OK, where do I see your comment? I also found some small details on the problem, is currently being revised one by one, and will submit a PR again after all the changes, please check again then, thank you ~

Sorry, I came back late from overtime. You can see this PR in your browser and scroll down.

Jinxiansen avatar Jan 18 '22 17:01 Jinxiansen

@Jinxiansen looks like the GH action was triggered - https://github.com/vapor/docs-cn/runs/4508150654?check_suite_focus=true. Does it need updating? What's missing?

Sorry, Tim, I'm not familiar with this part of the script. Tanner originally added this part of the action script task.

I am a little late after working overtime today, I will check it in my spare time.

Jinxiansen avatar Jan 18 '22 17:01 Jinxiansen

@CainLuo

Thanks again for helping to translate and sync these documents, it will help a lot of Chinese developers.

Also I've added some comments to the PR, if you have free time please check and consider revising. 🍻

@Jinxiansen OK, where do I see your comment? I also found some small details on the problem, is currently being revised one by one, and will submit a PR again after all the changes, please check again then, thank you ~

Sorry, I came back late from overtime. You can see this PR in your browser and scroll down.

@Jinxiansen Sorry, I didn't see a reply on PR, only your conversation with 0xTim. Am I not operating correctly somewhere?

CainLuo avatar Jan 19 '22 02:01 CainLuo

@CainLuo Please recheck these comments, you should be able to see it by now.

Jinxiansen avatar Jan 20 '22 12:01 Jinxiansen

@CainLuo Please recheck these comments, you should be able to see it by now.

好的,等我检查完之后再次提交合并~

CainLuo avatar Jan 27 '22 15:01 CainLuo

@CainLuo Hi, CainLuo. Do you have time to process these comments? It's not urgent. I would love to be able to merge your PR after you finish revising it.

Jinxiansen avatar Mar 12 '22 16:03 Jinxiansen

@Jinxiansen did this make it into the main repo or do we need to copy it over?

0xTim avatar May 16 '22 12:05 0xTim

@0xTim This is not included in the main repo yet, and looks like CainLuo is a little busy and may not have time to deal with this PR. I will try to copy the correct content in the PR and submit the PR to main Repo by the end of the week.

Jinxiansen avatar May 16 '22 12:05 Jinxiansen