async-kit icon indicating copy to clipboard operation
async-kit copied to clipboard

Published 20 hours ago • verified publisher icon vapor

Migrate to `NIOLock`

Open Colgates opened this issue 2 years ago • 2 comments

Migrates usages of Lock to NIOLock to fix deprecation warnings

Colgates avatar Oct 12 '22 04:10 Colgates

@Colgates looks like there are some build failures in the tests with 5.4

0xTim avatar Oct 12 '22 08:10 0xTim

Codecov Report

Merging #95 (de26df3) into main (c3329e4) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head de26df3 differs from pull request most recent head abed7ca. Consider uploading reports for the commit abed7ca to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          19       19           
  Lines        1199     1199           
=======================================
  Hits         1149     1149           
  Misses         50       50
Flag Coverage Δ
unittests 95.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ConnectionPool/EventLoopGroupConnectionPool.swift 94.77% <100.00%> (ø)

codecov-commenter avatar Oct 12 '22 09:10 codecov-commenter

The fixes from this PR are now included verbatim in #96 alongside a couple of additional cleanups, with authorship information duly noted; I'm going to close this PR out accordingly - thanks again for your work on this!

gwynne avatar Oct 31 '22 12:10 gwynne