ec2instances.info icon indicating copy to clipboard operation
ec2instances.info copied to clipboard

Sometimes it shows some old filtering with no clear indication of the fact that the filter is applied.

Open alexey-milovidov opened this issue 3 years ago • 14 comments

Maybe it is saved the filters into the local storage or cookies. But I don't see what the filter is.

alexey-milovidov avatar May 24 '22 20:05 alexey-milovidov

Yes, this is certainly a UX thing we want to improve. Can you try pressing Clear Filters and see if that resets?

EverettBerry avatar May 24 '22 20:05 EverettBerry

Yes, it helps.

alexey-milovidov avatar May 24 '22 22:05 alexey-milovidov

Ok thanks, closing this for now but stay tuned for some improvements in this area.

EverettBerry avatar May 24 '22 22:05 EverettBerry

Some kind of filter is applied every time I load/refresh the page. i.e. it's not just an old filter that's too sticky.

simsla-ml6 avatar Jun 24 '22 13:06 simsla-ml6

@simsla-ml6 if you press "Clear Filters" does it do help?

EverettBerry avatar Jun 24 '22 14:06 EverettBerry

It does, until I refresh.

simsla-ml6 avatar Jun 24 '22 14:06 simsla-ml6

Ok interesting - can you post a screen recording or describe in more detail then behavior you're seeing?

EverettBerry avatar Jun 24 '22 14:06 EverettBerry

I was just trying to take a screen recording and am now unable to reproduce. 😅

Disregard, I might've been doing something stupid.

simsla-ml6 avatar Jun 24 '22 14:06 simsla-ml6

No problem! I do think this a UX issue the way this works but we need to find a way to improve it while maintaining backwards compatibility for the folks who rely on this.

One way could be to add a save button. Right now the filter state is saved in local storage automatically.

EverettBerry avatar Jun 24 '22 14:06 EverettBerry

One issue is that when the list is filtered using one of the input boxes (e.g. API Name), the filter persists but the input box content does not.

e.g. in the below screenshot, a "c4" filter persists, but it's not clear from the UI which filter (if any) is in effect.

Screenshot 2022-06-24 at 17 37 20

simsla-ml6 avatar Jun 24 '22 15:06 simsla-ml6

That's a bug, mind opening an issue for this?

EverettBerry avatar Jun 24 '22 15:06 EverettBerry

Possibly related to #632 and #626

EverettBerry avatar Jun 24 '22 15:06 EverettBerry

Yes, I think it's probably the same as what @alexey-milovidov was describing when he created the current issue (#632).


To reproduce:

  • Clear Filters
  • Enter something in the API Name field
  • Refresh or browse to the site again

What should happen:

  • filter state matching with form state

What happens:

  • filter is in effect, but not visible in input field

MacOS 12.3 (21E230) -- M1 cpu Chrome Version 102.0.5005.115 (Official Build) (arm64) No errors / warnings in the console.

simsla-ml6 avatar Jun 24 '22 16:06 simsla-ml6

Also happening in #650

EverettBerry avatar Jul 28 '22 04:07 EverettBerry

This is an example of this not happening, image

When we loop through each column on page load we can check columns in Local Storage and fill in the field.

LocalStorage can be read using the state.loaded() api from DataTables, https://datatables.net/reference/api/state.loaded()

EverettBerry avatar Nov 26 '22 21:11 EverettBerry

This fix would also address #499

EverettBerry avatar Dec 06 '22 14:12 EverettBerry