ec2instances.info icon indicating copy to clipboard operation
ec2instances.info copied to clipboard

Add CPU Credits Data for Burstable Instance Types

Open jcgoette opened this issue 2 years ago • 5 comments

Data from https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/burstable-credits-baseline-concepts.html#earning-CPU-credits.

Tangentially related to https://github.com/vantage-sh/ec2instances.info/issues/147.

I'm happy to take a whack at this as time permits.

jcgoette avatar Nov 29 '21 15:11 jcgoette

Isn't this already covered by scrape.py:add_t2_credits()?

rishikhan avatar May 16 '22 22:05 rishikhan

yes, this should be there already

image

@jcgoette or were you maybe expecting something else?

cristim avatar May 18 '22 06:05 cristim

It's been awhile, but I think I meant adding data such as CPU credits earned per hour and Maximum earned credits that can be accrued. Unless that is somewhere I missed?

jcgoette avatar May 19 '22 02:05 jcgoette

I see. I've always just calculated those as Credits per hour = base performance60 and max credits = base perf60*24. I guess they could be added though.

The max credits is already on the website (not sure about the json file). The credits per hour is not, but it's just max credits/24.

With this info, how do you wish to proceed?

Rishi

On Wed, May 18, 2022, 10:43 PM Justin Goette @.***> wrote:

It's been awhile, but I think I meant adding data such as CPU credits earned per hour and Maximum earned credits that can be accrued. Unless that is somewhere I missed?

— Reply to this email directly, view it on GitHub https://github.com/vantage-sh/ec2instances.info/issues/596#issuecomment-1131054417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZFF2IINYMYXL7PNCVIBZTVKWTELANCNFSM5I7LT3ZA . You are receiving this because you commented.Message ID: @.***>

rishikhan avatar May 19 '22 02:05 rishikhan

We can probably add a derived column for this. We have many filters which are just multiplication (daily, weekly charges).

EverettBerry avatar May 19 '22 13:05 EverettBerry