ec2instances.info icon indicating copy to clipboard operation
ec2instances.info copied to clipboard

adding China regions

Open PatMyron opened this issue 6 years ago • 5 comments

https://github.com/powdahound/ec2instances.info/issues/330

similar to previous https://github.com/powdahound/ec2instances.info/pull/395

git clone https://github.com/patmyron/ec2instances.info
cd ec2instances.info
git remote add upstream https://github.com/powdahound/ec2instances.info
gh pr checkout 403
git fetch upstream
git rebase upstream/master
docker build -t ec2instances.info .
docker run -d --name some-container -p 8080:8080 ec2instances.info
open http://localhost:8080

PatMyron avatar Dec 10 '18 18:12 PatMyron

I'm a bit reluctant to merge this until we have the data available. It will just create confusion for people who expect to see the data but instead won't get anything.

cristim avatar Dec 10 '18 19:12 cristim

@cristim agreed

PatMyron avatar Dec 10 '18 19:12 PatMyron

@cristim https://github.com/powdahound/ec2instances.info/issues/330#issuecomment-448306433

PatMyron avatar Dec 18 '18 17:12 PatMyron

cfn-lint started picking up EC2/RDS/DAX instance type information from pricing for AWS China regions this month: https://github.com/aws-cloudformation/cfn-python-lint/pull/1635#discussion_r471975612 so I think it's worth reconsidering this now

PatMyron avatar Aug 18 '20 20:08 PatMyron

@PatMyron do you happen to know the latest on this? I think it would be cool to add pricing for China and can merge this in.

EverettBerry avatar Jul 25 '22 21:07 EverettBerry