jsoneditor-react icon indicating copy to clipboard operation
jsoneditor-react copied to clipboard

Published 20 hours ago • verified publisher icon vankop

Error is not cleared after a change without error

Open bruno-olivia opened this issue 5 years ago • 1 comments
trafficstars

Please, clear the variable this.err at the function handleChange before the line:

https://github.com/vankop/jsoneditor-react/blob/8c05a8be8e5598805fbac9c0aa53fc824043943b/src/Editor.jsx#L176

With it, I can just check the err variable at the editor to check if there is an error at the JSON

bruno-olivia avatar Apr 03 '20 13:04 bruno-olivia

This fix would be great. Since it doesn't clear, we can't reliably check this.err, and I would like to prevent saving in our app if there was still a valid error. If a PR would help speed this up, please let me know.

seanmalbert avatar Oct 12 '20 22:10 seanmalbert