Jean van Kasteel

code optimization

1

I realized doing some speedtests that we have many easy-to-make optimization we can include in the code. They mainly are related jQuery, and loops. To do: - [ ] go...

using webworkers for some cpu-intensive tasks

8

Such as webtorrent, for example. Although we might be limited to webrtc connexions, which would be bad.

Multiple sub providers

1

https://github.com/mpc-hc/mpc-hc/blob/develop/src/mpc-hc/SubtitlesProvider.cpp has: - Opensubtitles -> done: https://www.npmjs.com/package/opensubtitles-api - Yifysubtitles -> done: https://www.npmjs.com/package/yifysubtitles-api - SubDB -> make a module out of http://thesubdb.com/api/ or test https://github.com/ka2er/node-subdb-api - Titlovi -> make a module...

if there is 1 error amongst all posters for an item, all posters are removed, even those without error. Only the one that errored should be removed, and the container...

collection.state = 'error' is bugged

3

We have no access to errors anymore. The issue comes from list.js isEmpty() -> this.collection isn't updated when it autochecks getEmptyView();

item.js error handling

1

Error handling is really badly done. See https://github.com/butterproject/butter-desktop/blob/master/src/app/lib/views/browser/item.js#L197 that leaves the app hanging. The whole point of promises is to chain them, in this case it should be handled at...

- [ ] updateHealth() is fired too soon. - [ ] event duplication

The screen flickers while in fullscreen since nwjs >= 13 update. Fix is included in nwjs > 19.0

movie details view issues

3

- [x] things move around when opening/closing dropdowns, they should be on top of other thing, and not make small 'jumps' in the UI - [ ] Logs say "audio:none"...

It's shown even if there's nothing else to load. test by disabling CCC and leave youtube only