Paul Schaub issues

Results 121 issues of


                                            Paul Schaub

Fix some checkstyle issues in pg tests

This PR fixes some checkstyle issues caused by unused imports and misplaced curly brackets.

S2K: reuse type constants

Prevent PGP Signature Type 0xFF

The Crypto-Refresh specification [states](https://www.ietf.org/archive/id/draft-ietf-openpgp-crypto-refresh-13.html#name-reserved-type-id-0xff): > An implementation MUST NOT create any signature with this type \[0xFF\], and MUST NOT validate any signature made with this type. This PR prevents the...

Add support for parsing hardware-backed secret keys

See https://datatracker.ietf.org/doc/draft-dkg-openpgp-hardware-secrets/

Fix PGPEncryptedData.isAEAD() and abort verify() for AEAD encrypted data

Calling `pgpEncData.verify()` on AEAD encrypted data was throwing an NPE, as the `PGPEncryptedData` class was trying to read the MDC value from `truncStream` which is null at this point. I...

Add function tests for OpenPGP Ed25519,Ed448,X25519,X448 keys

This PR adds function tests for PGP keys based on Ed25519, Ed448, X25519, X448, LegacyEd25519 (EDDSA_LEGACY), LegacyCurve25519 (ECDH). Contrary to #1675 this PR does not test non-standard legacy X448, legacy...

LibrePGP V5 fingerprint calculation

This PR adds support for calculating the fingerprint of v5 LibrePGP keys. The v5 calculation is untested, as I cannot find an official test vector, though I'm pretty certain it...

Improve documentation of the S2K class

Add documentation to SecretKeyPacket members

Document PublicKeyPacket members

This PR adds javadoc documentation to all members of `PublicKeyPacket`. The only non-documentation change is the introduction and use of the `LIBREPGP_5` version number constant.