Paul Schaub
Paul Schaub
I'm contemplating whether to transform the `OpenPGPV6KeyGenerator` into a general `OpenPGPKeyGenerator` class, where the user can specify the key version number. There are some non-trivial differences between v4 and v6,...
Ready for review. Let me know if I can make your job easier by squashing or splitting this up into smaller PRs :)
One thing I dislike about the current API design: `PGPKeyPair` by default contains a primary key. Ideally I'd like to deal with an untyped key pair, whose type is determined...
Hey @ligefeiBouncycastle ! Thank you for the brief review :) I'm aware that breaking changes in the existing API shall be kept to an absolute minimum. Where possible, I try...
Note: It might make sense to split this PR up into smaller chunks (e.g. separate out all changes to the `/openpgp/` package). In #1911 I introduced new `OpenPGPCertificate`/`OpenPGPKey` classes, which...
> Please don't forget AEADProtectedPGPSecretKeyTest. reencryptKeyJca() function Good call!
I'm splitting this PR up into two parts, one focussed on changes in `/openpgp/`, `/openpgp/operator/` and `/bcpg/`, and finally another one adding the new `/openpgp/api/` classes.
This PR appears to now be part of the main branch.
Oops, I noticed that during a previous rebase I got some unrelated commits included in the patch. Fixed by rebasing once more on main.
Converted to draft, as the specification draft is still very experimental and the code point for hardware-backed s2k usage is also not yet finalized it seems.