Jonathan

Results 162 comments of Jonathan

Yes, it is subjective. This modification does away with the borders and use a more flat style. Try it and see if you like it. Might be something for the...

Then consider at least being consistent in the border color that is used, because now EasyMDE uses two different border colors, both `#bbb` and `#ddd` so it looks inconsistent and...

I would prefer `#ced4da` as that is what is used in Bootstrap. Else `#ccc` would be between `#bbb` and `#ddd` and closer to Bootstrap's `#ced4da` color. But this PR was...

Starting out by refactoring into a map #454

Yes, but then integrator would have to manually recreate their own custom buttons for every button. This commit separates concerns so it relies on a map which we can later...

Yeah, maybe, but then there is always the option for integrators to stay with the latest EasyMDE 2 version. I would hope to see this merged.

The problem it solves is it avoids any potential conflicts when using other libraries and code that might also use data attributes by putting all EasyMDE-related data attributes in its...

I see. I was not aware it was considered part of the public API. The data attribute is not mentioned in the documentation. If you don't want to merge it,...

Yeah, I saw that post. Good that you made a ref to it. GitHub includes "Projects" and "Labels" too which can be assigned to issues and pull requests.