4.0RC1: Theming issues

[bleistivt]

4.0RC1 breaks themes in several ways.

~~NewQuickLinks seems to be the only new theme feature that is enabled by default. Was this intended? https://github.com/vanilla/vanilla/blob/4c86174062b8e6563a952edda25cdacb71bb4d57/library/Vanilla/Theme/ThemeFeatures.php#L57~~

~~This requires adding the following to all old themes:~~

"Features": {
    "NewQuickLinks": false
}

fixed in https://github.com/vanilla/vanilla/commit/7cc3ce7c31e181d934514b78c6f8406f7b5c5e3a

body:not(.dataDriven) ... rules:

https://github.com/vanilla/vanilla/blob/5a3e583da1bfe585b5d2fe9ec452c368a14676b3/applications/dashboard/scss/legacy/_style.scss#L563 https://github.com/vanilla/vanilla/blob/5a3e583da1bfe585b5d2fe9ec452c368a14676b3/applications/dashboard/scss/legacy/_style.scss#L640

These rules have a really high specicifity and require theme authors to awkwardly add body:not(.dataDriven) to all .Button rules.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bleistivt]

Still relevant.