Issue with Vbulletin 4 Attachments Being Stripped Out

[MrCaspan]

vBulletin 4 uses BBCode to put images inline in a post. When looking at the code it stripes all the inline BBCode out of all posts... How would a user see the attachments on a post if you are removing the tags to show them. I have found that if you comments out these lines and leave that code in it and put the attachments in the proper upload directory on the new server Vanilla will produce links to the file..

This shoudl also be fixed they should be inline images not links to the files just like they were on the old forum

[MrCaspan]

https://github.com/vanilla/porter/blob/ec495d4ffce440d27ae0aa959d90c0a53c5502d0/packages/vbulletin.php#L505

https://github.com/vanilla/porter/blob/ec495d4ffce440d27ae0aa959d90c0a53c5502d0/packages/vbulletin.php#L550

As you can see here you are stripping out the BBCode in Discussions and Comments and replacing it with ' ' How would an inline image show if you are removing the code to show it?

[MrCaspan]

I recommend that you replace both lines with return $value; This way the BBCcode remains intact and it will properly reference to /attachemnts/userid/attachmentid.extension as I have tested this to be working

Please note the Attachment export issues (https://github.com/vanilla/porter/issues/194) has to be fixed first or you will have empty attachments to reference to