garden-cli icon indicating copy to clipboard operation
garden-cli copied to clipboard
verified publisher icon vanilla

49 - add explicit nullable declarations

Open mattgorle opened this issue 1 year ago • 3 comments

This should address #49 by adding the following explicit nullable declarations:

  1. Cli::parse: $argv
  2. Cli::validateType $def

The underlying issue is not visible when testing with PHP 8.4 and PHPUnit 8, so there is no clear difference when running the test suite.

However, when testing from an external project with PHP 8.4 and PHPUnit 12, two deprecation notices appear before the change and disappear after the change.

mattgorle avatar Feb 15 '25 11:02 mattgorle

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 15 '25 11:02 CLAassistant

Just ran into this issue and was about to report it, thanks for sending a patch

DanielEScherzer avatar Feb 17 '25 19:02 DanielEScherzer

Looks like main Vanilla project is abandoned from 2021 https://open.vanillaforums.com/discussion/39558/official-releases-have-ended and things are not getting merged.

elcreator avatar May 01 '25 14:05 elcreator