vanilla-extract icon indicating copy to clipboard operation
vanilla-extract copied to clipboard

css, integration: Replace `outdent` dependency with `dedent`

Open askoufis opened this issue 1 year ago • 1 comments

Really the only reason to move is that dedent seems much more actively maintained than outdent.

askoufis avatar Apr 20 '24 05:04 askoufis

🦋 Changeset detected

Latest commit: 456545bc58974bfb80aa218aa23d133b0dc51d31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@vanilla-extract/integration Patch
@vanilla-extract/css Patch
@vanilla-extract-private/tests Patch
@fixtures/features Patch
@fixtures/layers Patch
@fixtures/low-level Patch
@fixtures/next-app-router Patch
@fixtures/next-pages-router Patch
@fixtures/recipes Patch
@fixtures/sprinkles Patch
@fixtures/template-string-paths Patch
@fixtures/themed Patch
@fixtures/thirdparty Patch
@fixtures/unused-modules Patch
@fixtures/thirdparty-dep Patch
@fixtures/thirdparty-dep-dep Patch
vanilla-extract-example-remix Patch
vanilla-extract-example-webpack-react Patch
@vanilla-extract-private/test-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 20 '24 05:04 changeset-bot[bot]

I think this change broke something in how dedenting works when passing a multiline string in @vanilla-extract/css.

import { createGlobalTheme } from "@vanilla-extract/css";

const vars = createGlobalTheme(":root", {
  focusWithin: {
    highlightBoxShadow: `
      0px 0px 0px 4px #DEEFFF
    `,
  },
});

This works fine in 1.15.0, but with 1.15.1 the backticks are turned into ", which is a syntax error.

It might not be the change in this PR, but it who knows 🙂 It broke in the patch release this PR was included in at least

SimenB avatar May 02 '24 10:05 SimenB

I think this change broke something in how dedenting works when passing a multiline string in @vanilla-extract/css.

import { createGlobalTheme } from "@vanilla-extract/css";

const vars = createGlobalTheme(":root", {
  focusWithin: {
    highlightBoxShadow: `
      0px 0px 0px 4px #DEEFFF
    `,
  },
});

This works fine in 1.15.0, but with 1.15.1 the backticks are turned into ", which is a syntax error.

It might not be the change in this PR, but it who knows 🙂 It broke in the patch release this PR was included in at least

I can't seem to reproduce this. This is the CSS that I'm seeing generated. It looks a bit weird, but is otherwise completely functional:

image

If you find a minimal reproduction, please raise a separate issue.

askoufis avatar May 03 '24 05:05 askoufis

Fair enough 😀

https://github.com/vanilla-extract-css/vanilla-extract/issues/1405

SimenB avatar May 03 '24 07:05 SimenB