seq2science icon indicating copy to clipboard operation
seq2science copied to clipboard

FR: auto-formatting

Open siebrenf opened this issue 4 years ago • 5 comments

what Would we like to implement a pre-commit hook/test step which performs formatting?

how Snakemake's own version of black, snakefmt, is working in most cases. By running it on 1 file at a time, cryptic errors are slightly more clear.

example with a line-length of 122 (arbitrary, but we've used it because of pycharm)

mamba install snakefmt

for file in seq2science/rules/*; do 
  snakefmt -l 122 $file
done

siebrenf avatar Jun 02 '21 16:06 siebrenf

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] avatar Jul 01 '21 03:07 stale[bot]

I think a non-optional test could be nice. Not sure how buggy/time consuming it would be to make what we have now work with snakefmt

Maarten-vd-Sande avatar Dec 06 '21 10:12 Maarten-vd-Sande

Snakefmt improves readability a bit, but still needs supervision. Lets keep this open for now, and I'll make a PR manually this time.

siebrenf avatar Dec 06 '21 17:12 siebrenf

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] avatar Apr 16 '22 13:04 stale[bot]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] avatar Jul 10 '22 09:07 stale[bot]