librevox icon indicating copy to clipboard operation
librevox copied to clipboard

CommandSocket#command

Open bit4bit opened this issue 12 years ago • 3 comments

When i call CommandSocket#command :show, :calls it content is empty

but when i try

CommandSocket#command :show, :tasks it has content

so, the problem was in Response#content= who do @content = content.match(/:/) ? headers_2_hash(content) : content this ok, but when the content, for example include. ....sip:1000@....

but in CommandSocket is a bug.

bit4bit avatar Feb 26 '12 03:02 bit4bit

Thank you. I need to revamp the CommandSocket tests. As soon as this is done I'll merge this in.

vangberg avatar Feb 26 '12 14:02 vangberg

CommandSocket is evil and not EM aware (unless you monkeypatch TCPSocket). Same can be achieved using Listener::Inbound.

pirj avatar Aug 14 '12 12:08 pirj

CommandSocket still makes sense, in particular because it's not EM, it makes it simpler to use for e.g. one off scripts etc. Might rip it out in a separate gem, though.

vangberg avatar Aug 14 '12 20:08 vangberg