Valithor Obsidion
Valithor Obsidion
ExtendedPromiseInterface extends PromiseInterface, and Promise v2 implements ExtendedPromiseInterface, so instead of replacing the existing typehinting to PromiseInterface we _could_ just use React\Promise\Promise, which would overcome the hurdle and be better...
> It's painful to read this @valzargaming :) Code-ify more please. This is already coded in the promises v3 branch as of today.
Closed as fix was provided but no confirmation for 4 months
Thanks for taking the time to look this over @SimonFrings! It has been rather hard to reproduce and only happens from time to time (usually when a fatal error is...
I've finally been able to replicate the issue! It turns out that it's not related (at least not always) to the socket not closing when the script stops, but rather...
This issue extends to interfaces as well, only functions defined in the class are observed. The same assumption cannot be made as the class is not valid unless those functions...
I attempted to replicate these changes and check for any areas of improvement on my own branch, but it seems to have been entirely unnecessarily. I am fine with merging...
> > Ratchet/pawl has a dependency on Promise V2, not specified in its composer files however > > Two things. > > 1. Depending on an apparently abandoned package that...
I've poked about for a bit and I see no reason to further delay this PR. We can look into other options in the future if needed, but this should...
I'm running out of time to be able to work on this, if someone can please finish this up.