Question: Add client.MaxResponseBody*Read*Size?

[osxtest]

Hi, thanks for the great lib.

I'm encountering the same issue as described in issue https://github.com/valyala/fasthttp/issues/686. By setting Client.MaxResponseBodySize, it returns ErrBodyTooLarge when the response body length exceeds this value.

However, I would still like to read part of the response body instead of receiving an error, and also prevent potential DOS attacks caused by large responses.

Would it be possible to provide a configuration similar to client.MaxResponseBody*Read*Size? This would be similar to what's implemented in retryablehttp-go.

Thanks!

[osxtest]

A naive modification could be to treat MaxResponseBodySize as MaxResponseBodyReadSize, and make changes at the Response.ReadBody:

func (resp *Response) ReadBody(r *bufio.Reader, maxBodySize int) (err error) {
	bodyBuf := resp.bodyBuffer()
	bodyBuf.Reset()

	contentLength := resp.Header.ContentLength()
	switch {
	case contentLength >= 0:
+		if maxBodySize > 0 && contentLength > maxBodySize {
+			contentLength = maxBodySize
+		}
		bodyBuf.B, err = readBody(r, contentLength, maxBodySize, bodyBuf.B)
		if err == ErrBodyTooLarge && resp.StreamBody {
			resp.bodyStream = acquireRequestStream(bodyBuf, r, &resp.Header)
			err = nil
		}
	case contentLength == -1:
		...

By doing so, I think it could mitigate the issue (maybe not) of fasthttp always reading the whole body into memory.

[erikdubbelboer]

Something like that could work but it would still have to return an error. It will leave the connection in a broken state with a partially read body. It will also fail completely if the response uses chunk encoding and the first chunk by itself is already too big. It will always exclude the last chunk as it can't read that without fitting in the max size. And there are probably other edge cases that need to be considered.

I'm afraid I don't have time to work on this, a pull request is always welcome.