korona-info icon indicating copy to clipboard operation
korona-info copied to clipboard

Published 20 hours ago • verified publisher icon valstu

Adding Russian translation

Open MrKalach opened this issue 4 years ago • 5 comments

MrKalach avatar Mar 31 '20 07:03 MrKalach

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/valstu/korona/pnmiqzjmc ✅ Preview: https://korona-git-fork-mrkalach-rutranslation.valstu.now.sh

vercel[bot] avatar Mar 31 '20 07:03 vercel[bot]

Hey @valstu! Any chance to merge it?

MrKalach avatar Apr 01 '20 07:04 MrKalach

Yeah, this looks good, we added few new translation keys for the bubble chart yesterday so those could be added. I just need to figure out a way to show all these translations since there are 3 other PRs waiting and the current language selecter needs to be restyled.

valstu avatar Apr 01 '20 07:04 valstu

Maybe move all translations to separate files to utils/translations/{LANG}-translation.ts? Then dynamically include them (not sure, is it possible in TS)? Every include could itself add data to global phrases: { [key: string]: { [key: string]: string } } ?

ps. I'm very far from TS and web dev. And maybe my ^^^ proposal is so stupid :)

MrKalach avatar Apr 01 '20 08:04 MrKalach

@valstu I did update the PR. Conflicts fix.

MrKalach avatar Apr 03 '20 17:04 MrKalach