odin
odin copied to clipboard
Add ZipFileLogger
The zipper
vs logger
blocking is done via a BiSemaphore
that allows logger
calls to happen concurrently.
The param zipNamePattern
uses logback style: output.%d{yyyy-MM-dd}.log.zip
Codecov Report
Merging #115 into master will increase coverage by
0.72%
. The diff coverage is97.77%
.
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 93.33% 94.05% +0.72%
==========================================
Files 32 33 +1
Lines 465 555 +90
Branches 9 10 +1
==========================================
+ Hits 434 522 +88
- Misses 31 33 +2
Flag | Coverage Δ | |
---|---|---|
#unittests | 94.05% <97.77%> (+0.72%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
...src/main/scala/io/odin/loggers/ZipFileLogger.scala | 97.77% <97.77%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e94b643...0acc617. Read the comment docs.
Hi @CharlesD91
As a heads up, I need some time to digest it. I'll take a good look at it this week I hope
Hi @sergeykolbasov ,
Any chance you had the time to look at this PR ?
Thank you for your time and for an awesome project !