open-autonomy icon indicating copy to clipboard operation
open-autonomy copied to clipboard

Feature request: No clean up post scaffold failure.

Open 8ball030 opened this issue 1 year ago • 1 comments

Subject of the issue

There is no clean up when scaffolding a fsm which fails validation

i.e. when running;

autonomy scaffold -tlr fsm --spec fsm_spec.yaml eightballer

I get the following error as I have poorly defined my fsm;

autonomy.analyse.abci.app_spec.DFASpecificationError: DFA spec has the following issues:
 - Transitions out from final states: {'ObjectiveComplete'}

I would expect that if the command fails, it does not create artefacts, or cleans them up post failure.

Presently, the application will leave artefacts on the users working directory which must be cleaned, if we validate the spec prior to creating the artefacts, the users wont have to clean their working directory

Your environment

  • OS: [e.g. iOS]
  • Python version: [e.g. 3.7.2]
  • Package Version [e.g. 0.1.3]
  • Anything else you consider helpful.

Steps to reproduce

Tell us how to reproduce this issue.

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

8ball030 avatar Mar 04 '23 21:03 8ball030

Yes, 100% agree.

dvilelaf avatar Mar 06 '23 14:03 dvilelaf