wallet icon indicating copy to clipboard operation
wallet copied to clipboard

fix(points): app mount sagas have not been running

Open bakoushin opened this issue 1 year ago • 1 comments

Description

I noticed that points app mount sagas have not been running and apparently they have to be wrapped into call methods to run.

To the worse, the initial unit test was wrong and didn't catch this issue -- it relied on mock functions being called within the test, which created illusion of success.

Test plan

  • Tested manually
  • Updated unit tests

Related issues

NA

Backwards compatibility

Y

Network scalability

NA

bakoushin avatar May 24 '24 19:05 bakoushin

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.38%. Comparing base (2d67174) to head (226bd3f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5466      +/-   ##
==========================================
- Coverage   86.39%   86.38%   -0.02%     
==========================================
  Files         761      761              
  Lines       31357    31357              
  Branches     5389     5389              
==========================================
- Hits        27092    27088       -4     
- Misses       4034     4038       +4     
  Partials      231      231              
Files Coverage Δ
src/points/saga.ts 84.49% <0.00%> (-2.33%) :arrow_down:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d67174...226bd3f. Read the comment docs.

codecov[bot] avatar May 24 '24 19:05 codecov[bot]

closing in favor of #5479

bakoushin avatar May 27 '24 17:05 bakoushin