wallet
wallet copied to clipboard
feat(points): points entry point and intro screen
Description
- Add points card to the "Discover" screen
- Add an intro screen to the points home page (shown only once)
https://github.com/valora-inc/wallet/assets/2737872/ef769852-a628-4e4c-8ce1-63ffcbb0345b
Test plan
Updated unit tests
Related issues
- Fixes RET-1077
Backwards compatibility
NA
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:
- [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
1 build increased size
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
Celo (test) org.celo.mobile.test |
1.84.0 (149) | 27.1 MB | ⬆️ 96.0 kB (0.36%) | 64.4 MB | ⬆️ 111.8 kB (0.17%) | N/A |
Celo (test) 1.84.0 (149)
org.celo.mobile.test
⚖️ Compare build 📦 Install build ⏱️ Analyze build performance
Total install size change: ⬆️ 111.8 kB (0.17%) Total download size change: ⬆️ 96.0 kB (0.36%)
Largest size changes
Item | Install Size Change |
---|---|
📝 [email protected] | ⬆️ 57.3 kB |
📝 [email protected] | ⬆️ 32.8 kB |
📝 points-illustration.png | ⬆️ 12.3 kB |
main.jsbundle | ⬆️ 4.1 kB |
Other | ⬆️ 5.3 kB |
:flying_saucer: Powered by Emerge Tools
Codecov Report
Attention: Patch coverage is 98.63014%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 86.23%. Comparing base (
c49d3f5
) to head (9ba786d
).
Additional details and impacted files
@@ Coverage Diff @@
## main #5406 +/- ##
==========================================
+ Coverage 86.20% 86.23% +0.03%
==========================================
Files 748 750 +2
Lines 30474 30529 +55
Branches 5196 5198 +2
==========================================
+ Hits 26271 26328 +57
+ Misses 3975 3973 -2
Partials 228 228
Files | Coverage Δ | |
---|---|---|
branding/celo/src/images/points-illustration.png | 100.00% <ø> (ø) |
|
src/analytics/Events.tsx | 100.00% <100.00%> (ø) |
|
src/analytics/Properties.tsx | 100.00% <ø> (ø) |
|
src/dappsExplorer/TabDiscover.tsx | 95.86% <100.00%> (+0.03%) |
:arrow_up: |
src/images/Images.ts | 100.00% <100.00%> (ø) |
|
src/navigator/Headers.tsx | 60.00% <ø> (-2.00%) |
:arrow_down: |
src/navigator/Screens.tsx | 100.00% <100.00%> (ø) |
|
src/points/PointsDiscoverCard.tsx | 100.00% <100.00%> (ø) |
|
src/points/selectors.ts | 92.85% <100.00%> (+0.35%) |
:arrow_up: |
src/points/slice.ts | 64.51% <100.00%> (+1.18%) |
:arrow_up: |
... and 4 more |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c49d3f5...9ba786d. Read the comment docs.
@jeanregisser what kind of animation would you expect?
@jeanregisser what kind of animation would you expect?
Not sure. Some kind of navigation animation (slide down, slide left/right).