wallet
wallet copied to clipboard
feat: earn asset details for aaveUSDC
Description
Expands on the work in #5400 to allow the multiple button types and pools in EarnCard.tsx. This abstraction should now work for any Aave v3 pools on any network and sets up the ability to handle multiple pools with only layout changes needed when designs are ready.
Test plan
- [x] Tested locally on iOS
- [x] Tested locally on Android
- [x] Unit tests added and updated
Related issues
- Fixes ACT-1185
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:
- [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Codecov Report
Attention: Patch coverage is 90.47619% with 6 lines in your changes are missing coverage. Please review.
Project coverage is 86.14%. Comparing base (
93f2ab1) to head (1e73a5d). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5403 +/- ##
==========================================
+ Coverage 86.12% 86.14% +0.01%
==========================================
Files 744 744
Lines 30267 30291 +24
Branches 5171 5181 +10
==========================================
+ Hits 26068 26093 +25
+ Misses 3971 3970 -1
Partials 228 228
| Files | Coverage Δ | |
|---|---|---|
| src/analytics/Events.tsx | 100.00% <100.00%> (ø) |
|
| src/analytics/Properties.tsx | 100.00% <ø> (ø) |
|
| src/dappsExplorer/TabDiscover.tsx | 95.83% <100.00%> (ø) |
|
| src/earn/poolInfo.ts | 86.36% <100.00%> (+1.36%) |
:arrow_up: |
| src/tokens/TokenDetails.tsx | 100.00% <100.00%> (ø) |
|
| src/earn/EarnCard.tsx | 95.65% <95.65%> (ø) |
|
| src/earn/EarnActivePool.tsx | 89.09% <81.48%> (+7.27%) |
:arrow_up: |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 93f2ab1...1e73a5d. Read the comment docs.