wallet
wallet copied to clipboard
feat(earn): Add enter amount screen
Description
Add EarnEnterAmount screen.
Test plan
Unit tests added.
Manual tests:
When a user has USDC on arbitrum:
https://github.com/valora-inc/wallet/assets/140328381/5103c167-3447-4df5-bb86-2318bf2c021a
When a user doesn't have enough USDC on arbitrum:
https://github.com/valora-inc/wallet/assets/140328381/459a6671-e8bc-42ca-84ef-e8c6d104a427
Clicking the info button:
https://github.com/valora-inc/wallet/assets/140328381/86c47948-61c2-4c1b-89b9-b02be943f534
Related issues
- Fixes #ACT-1176
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:
- [X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Codecov Report
Attention: Patch coverage is 80.63063%
with 43 lines
in your changes are missing coverage. Please review.
Project coverage is 86.29%. Comparing base (
85a9d0c
) to head (b1f5a6d
).
Additional details and impacted files
@@ Coverage Diff @@
## main #5399 +/- ##
==========================================
- Coverage 86.35% 86.29% -0.06%
==========================================
Files 755 756 +1
Lines 30942 31162 +220
Branches 5281 5338 +57
==========================================
+ Hits 26719 26891 +172
- Misses 3996 4039 +43
- Partials 227 232 +5
Files | Coverage Δ | |
---|---|---|
src/analytics/Events.tsx | 100.00% <100.00%> (ø) |
|
src/analytics/Properties.tsx | 100.00% <ø> (ø) |
|
src/components/TokenIcon.tsx | 100.00% <100.00%> (ø) |
|
src/earn/EarnCard.tsx | 95.65% <100.00%> (ø) |
|
src/earn/EarnCta.tsx | 100.00% <100.00%> (ø) |
|
src/navigator/Screens.tsx | 100.00% <100.00%> (ø) |
|
src/send/EnterAmount.tsx | 96.22% <100.00%> (+0.01%) |
:arrow_up: |
src/statsig/constants.ts | 100.00% <ø> (ø) |
|
src/earn/prepareTransactions.ts | 89.33% <50.00%> (-6.06%) |
:arrow_down: |
src/earn/EarnEnterAmount.tsx | 81.00% <81.00%> (ø) |
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 85a9d0c...b1f5a6d. Read the comment docs.
1 build increased size
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
Celo (test) org.celo.mobile.test |
1.85.0 (150) | 27.1 MB | ⬆️ 13.0 kB (0.05%) | 64.5 MB | ⬆️ 32.8 kB (0.05%) | N/A |
Celo (test) 1.85.0 (150)
org.celo.mobile.test
⚖️ Compare build 📦 Install build ⏱️ Analyze build performance
Total install size change: ⬆️ 32.8 kB (0.05%) Total download size change: ⬆️ 13.0 kB (0.05%)
Largest size changes
Item | Install Size Change |
---|---|
main.jsbundle | ⬆️ 32.8 kB |
:flying_saucer: Powered by Emerge Tools
Follow up issue to use EnterAmount: https://linear.app/valora/issue/ACT-1199/placeholder-clean-up-have-earnenteramount-use-enteramount-component