wallet icon indicating copy to clipboard operation
wallet copied to clipboard

feat(swap): track valora fee

Open jeanregisser opened this issue 9 months ago • 1 comments

Description

As the title says.

Test plan

  • Updated tests

Related issues

  • Fixes RET-1061

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

jeanregisser avatar Apr 30 '24 07:04 jeanregisser

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.07%. Comparing base (a4ca31c) to head (b1e5ac1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5368   +/-   ##
=======================================
  Coverage   86.06%   86.07%           
=======================================
  Files         735      735           
  Lines       29984    29984           
  Branches     5139     5139           
=======================================
+ Hits        25806    25808    +2     
+ Misses       3951     3949    -2     
  Partials      227      227           
Files Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/swap/SwapScreen.tsx 94.01% <100.00%> (ø)
src/swap/saga.ts 94.51% <ø> (ø)
src/swap/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4ca31c...b1e5ac1. Read the comment docs.

codecov[bot] avatar Apr 30 '24 07:04 codecov[bot]