wallet icon indicating copy to clipboard operation
wallet copied to clipboard

feat: use biometrics without pin set first in onboarding

Open MuckT opened this issue 1 year ago • 1 comments

Description

Enables users to use biometrics during onboarding for a streamlined onboarding experience. Will be hooked up to an experiment to measure impact.

Test plan

  • [x] Tested locally on Android
  • [ ] Tested locally on iOS
  • [ ] Unit tests added

Related issues

  • Fixes ACT-1160

Backwards compatibility

Yes - existing users will all have set their pin manually so redux migration sets this value.

Network scalability

N/A

MuckT avatar Apr 24 '24 01:04 MuckT

Codecov Report

Attention: Patch coverage is 48.78049% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 86.00%. Comparing base (13d98f8) to head (bf4542a).

:exclamation: Current head bf4542a differs from pull request most recent head c7ba5e8. Consider uploading reports for the commit c7ba5e8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5312      +/-   ##
==========================================
- Coverage   86.06%   86.00%   -0.06%     
==========================================
  Files         735      747      +12     
  Lines       29952    30658     +706     
  Branches     5125     5316     +191     
==========================================
+ Hits        25778    26368     +590     
- Misses       3947     4057     +110     
- Partials      227      233       +6     
Files Coverage Δ
src/analytics/Events.tsx 100.00% <100.00%> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/app/actions.ts 95.69% <100.00%> (+1.25%) :arrow_up:
src/app/selectors.ts 94.64% <100.00%> (+0.76%) :arrow_up:
src/navigator/Screens.tsx 100.00% <100.00%> (ø)
src/onboarding/registration/EnableBiometry.tsx 100.00% <100.00%> (ø)
src/pincode/PincodeSet.tsx 94.78% <100.00%> (+0.09%) :arrow_up:
src/redux/migrations.ts 97.02% <100.00%> (-0.02%) :arrow_down:
src/redux/store.ts 78.68% <ø> (ø)
test/schemas.ts 90.25% <100.00%> (-0.07%) :arrow_down:
... and 4 more

... and 83 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13d98f8...c7ba5e8. Read the comment docs.

codecov[bot] avatar Apr 24 '24 02:04 codecov[bot]

Closing as the investigative spike is complete in ACT-1160.

MuckT avatar May 06 '24 18:05 MuckT