wallet
wallet copied to clipboard
chore: Remove old CeloGoldHistoryChart
Description
- Usage of CeloGoldHistoryChart removed
- exchangeHistorySelector usage replaced with token.historicalPricesUsd.lastDay
- sage/reducer/action cleaned up
- exchange folder remaned to celoNews
Test plan
builds, root state schema updated
Related issues
- Fixes #ACT-1039
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:
- N/A
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.04%. Comparing base (
3846796
) to head (bd466f8
).
Additional details and impacted files
@@ Coverage Diff @@
## main #5307 +/- ##
==========================================
+ Coverage 85.92% 86.04% +0.12%
==========================================
Files 738 735 -3
Lines 30173 29948 -225
Branches 5168 5123 -45
==========================================
- Hits 25925 25770 -155
+ Misses 4016 3951 -65
+ Partials 232 227 -5
Files | Coverage Δ | |
---|---|---|
src/account/utils.ts | 100.00% <100.00%> (ø) |
|
src/alert/reducer.ts | 64.70% <100.00%> (-5.30%) |
:arrow_down: |
src/analytics/Events.tsx | 100.00% <ø> (ø) |
|
src/analytics/Properties.tsx | 100.00% <ø> (ø) |
|
src/app/reducers.ts | 22.82% <ø> (ø) |
|
src/app/saga.ts | 73.16% <100.00%> (ø) |
|
src/celoNews/CeloNewsFeed.tsx | 97.14% <100.00%> (ø) |
|
src/celoNews/CeloNewsFeedItem.tsx | 100.00% <ø> (ø) |
|
src/firebase/saga.ts | 67.30% <100.00%> (+24.14%) |
:arrow_up: |
src/redux/migrations.ts | 97.04% <100.00%> (+<0.01%) |
:arrow_up: |
... and 8 more |
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3846796...bd466f8. Read the comment docs.
1 build decreased size
Name | Version | Download | Change | Install | Change | Approval |
---|---|---|---|---|---|---|
Celo (test) org.celo.mobile.test |
1.83.0 (148) | 27.5 MB | ⬇️ 5.7 kB (-0.02%) | 65.6 MB | ⬇️ 16.4 kB (-0.03%) | N/A |
Celo (test) 1.83.0 (148)
org.celo.mobile.test
⚖️ Compare build 📦 Install build ⏱️ Analyze build performance
Total install size change: ⬇️ 16.4 kB (-0.03%) Total download size change: ⬇️ 5.7 kB (-0.02%)
Largest size changes
Item | Install Size Change |
---|---|
main.jsbundle | ⬇️ -16.4 kB |
:flying_saucer: Powered by Emerge Tools