wallet icon indicating copy to clipboard operation
wallet copied to clipboard

fix: handle large fonts with twelve word seed phrases

Open MuckT opened this issue 1 year ago • 2 comments

Description

Currently large fonts can display the 12 word seed phrase with letters rendered off screen or covered index numbers. This PR fixes that by using the fontScale to display as either four rows with three columns or six rows with two columns.

Screenshots

iOS Large Font (Before) iOS Large Font (After) iOS Default Font (Before) iOS Default Font (After)
Android Large Font (Before) Android Large Font (After) Android Default Font (Before) Android Default Font (After)

Test plan

  • Tested locally on iOS
  • Tested locally on Android

Related issues

  • Fixes ACT-1073

Backwards compatibility

Yes

Network scalability

N/A

MuckT avatar Mar 29 '24 21:03 MuckT

1 build had no size change

Name Version Download Change Install Change Approval
Celo (test)
org.celo.mobile.test
1.81.0 (146) 24.3 MB ⬆️ 650 B 60.9 MB - N/A

Celo (test) 1.81.0 (146)
org.celo.mobile.test

No changes to report


:flying_saucer: Powered by Emerge Tools

emerge-tools[bot] avatar Mar 29 '24 21:03 emerge-tools[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.77%. Comparing base (03d2f21) to head (bffd1d6). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5187      +/-   ##
==========================================
+ Coverage   85.76%   85.77%   +0.01%     
==========================================
  Files         744      744              
  Lines       30324    30343      +19     
  Branches     5237     5238       +1     
==========================================
+ Hits        26007    26028      +21     
+ Misses       4078     4076       -2     
  Partials      239      239              
Files Coverage Δ
src/backup/BackupPhraseContainer.tsx 86.36% <100.00%> (+0.64%) :arrow_up:

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03d2f21...bffd1d6. Read the comment docs.

codecov[bot] avatar Mar 29 '24 21:03 codecov[bot]