fix: feed item alignment and 'account' removal

[MuckT]

Description

Aligns the feedItems from send and receive with swap item styles and removes the word 'account' from free item titles.

Other changes

Align text right on swap items in feed.

Screenshots

Extra Large Font Size - Before / After

       

Large Font Size - Before / After

       

Default Font Size - Before / After

       

Tested

Tested locally on an iOS 12 mini.

How others should test

With an account with at least one swap and one send transaction ensure that feed items on the home screen align. Observe that the word 'account' is removed from the feed item title.

Related issues

N/A - There was an old issue for removing account, but I am unable to find it currently.

Backwards compatibility

Yes

[MuckT]

@jeanregisser heres a comment with a really long description.

Before / After Default Font Size

       

Before / After Extra Large Font Size

       

[codecov[bot]]

Codecov Report

Merging #2810 (2baf4f4) into main (7c8887a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2baf4f4 differs from pull request most recent head 3aa8906. Consider uploading reports for the commit 3aa8906 to get more accurate results

@@           Coverage Diff           @@
##             main    #2810   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         608      608           
  Lines       22009    22009           
  Branches     4005     4005           
=======================================
  Hits        17573    17573           
  Misses       4387     4387           
  Partials       49       49           

Impacted Files	Coverage Δ
src/transactions/feed/SwapFeedItem.tsx	92.30% <ø> (ø)
src/transactions/feed/TransferFeedItem.tsx	93.33% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c8887a...3aa8906. Read the comment docs.

[jeanregisser]

Thanks @MuckT From what I see the description is wrapped a bit too early with these changes. The amount (right) and text (left) wrappers are split in half, when it would probably be better to grow if there's more space available. What do you think?

[MuckT]

@jeanregisser I agree with the text being a bit small on the changes. I'll look at having them grow if there is room.

[MuckT]

@jeanregisser adjusted in https://github.com/valora-inc/wallet/pull/2810/commits/e3600538cb4a33661541528c8bd63ca0cc3439e8

Before / After Default Font Size

       

Before / After Extra Large Font Size

       

[ValoraQA]

Hey @MuckT we have verified the above task on Latest iOS Test Flight Release build V 1.40.0 and updated status in test rails

Observation :

• User is not able to see "account" word besides account address for send / received payment on recent transaction activity page
• User is not able to see "account" word besides account address for Buy / Sell Celo on recent transaction activity page
• User is able to see proper alignment of text ,amount and other details after the font is set to maximum.

Test Rails: iOS 15 : https://valoraapp.testrail.io/index.php?/tests/view/69498 iOS 14: https://valoraapp.testrail.io/index.php?/tests/view/69529

Device : iPhone 13 mini(15.1.1) , iPhone 12(14.7.1)

Thanks..!

[ValoraQA]

Hey @MuckT we have verified the above task on Latest Android Internal Release build V 1.40.0 and updated status in test rails

Observation :

• User is not able to see "account" word besides account address for send / received payment on recent transaction activity page
• User is not able to see "account" word besides account address for Buy / Sell Celo on recent transaction activity page
• User is able to see proper alignment of text ,amount and other details after the font is set to maximum.

Test Rails link: Android 12: https://valoraapp.testrail.io/index.php?/tests/view/69591 Android 11: https://valoraapp.testrail.io/index.php?/tests/view/69560

Device: Google Pixel 4a(12.0), Google Pixel 2XL(11.0)

Thanks..!