wallet
wallet copied to clipboard
WIP: Cash-in support for cREAL
Description
Celo Brazilian Reales cash-in are supported through this PR
Compromise
Due to changing the types in currencies.ts
or upgrading @celo/contractkit
would substantially magnify the scope of changes, places where cREAL is added have their types changed to Currency | 'cREAL'
, and accompanying logic added. The type is asserted back into Currency
when it is determined that the app is not doing cREAL cash-in flow.
Other changes
None
Tested
(To be written)
How others should test
(To be written)
Related issues
- Fixes ACT-390
Backwards compatibility
Compatible. A user with previous version of wallet will not be sending any cReal related interacions with backend services; related backend services are expected in this PR to handle non cReal requests in the same way.
📏 Size Analysis
Total install size 68.1 MB | This change does not effect size 🌴
🔎 See the full size analysis (029cf79) merging into main (238bdc8)
Codecov Report
Merging #2785 (a3c1b7e) into main (238bdc8) will decrease coverage by
0.08%
. The diff coverage is58.18%
.
:exclamation: Current head a3c1b7e differs from pull request most recent head 029cf79. Consider uploading reports for the commit 029cf79 to get more accurate results
@@ Coverage Diff @@
## main #2785 +/- ##
==========================================
- Coverage 79.80% 79.71% -0.09%
==========================================
Files 605 605
Lines 21888 21921 +33
Branches 3996 4001 +5
==========================================
+ Hits 17468 17475 +7
- Misses 4370 4395 +25
- Partials 50 51 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/components/TokenDisplay.tsx | 100.00% <ø> (ø) |
|
src/components/TotalLineItem.tsx | 96.00% <ø> (ø) |
|
src/fiatExchanges/quotes/NormalizedQuote.ts | 100.00% <ø> (ø) |
|
src/localCurrency/hooks.ts | 58.92% <36.36%> (-18.35%) |
:arrow_down: |
src/components/CurrencyDisplay.tsx | 75.65% <50.00%> (-1.34%) |
:arrow_down: |
src/fiatExchanges/ExternalExchanges.tsx | 80.00% <50.00%> (-1.14%) |
:arrow_down: |
src/fiatExchanges/FiatExchangeCurrency.tsx | 73.07% <50.00%> (-2.40%) |
:arrow_down: |
src/fiatExchanges/SelectProvider.tsx | 87.50% <50.00%> (-0.53%) |
:arrow_down: |
src/fiatExchanges/FiatExchangeAmount.tsx | 88.46% <66.66%> (+1.24%) |
:arrow_up: |
src/fiatExchanges/quotes/ExternalQuote.ts | 93.22% <66.66%> (-6.78%) |
:arrow_down: |
... and 83 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 238bdc8...029cf79. Read the comment docs.