ngx-bootstrap icon indicating copy to clipboard operation
ngx-bootstrap copied to clipboard

feat(animations): add animations to all components

Open masiamj opened this issue 9 years ago • 63 comments

Blocked by: https://github.com/angular/angular/issues/9947

Are animations for the accordion, alerts, etc. on the roadmap for this project? Would be huge to further reflect fully-featured Bootstrap components.

masiamj avatar Jul 29 '16 16:07 masiamj

+1

jurienhamaker avatar Aug 09 '16 11:08 jurienhamaker

Yes, could someone please advise the timeline for releasing the transition module?

qjnz avatar Aug 10 '16 23:08 qjnz

Hi guys, from this file \ng2-bootstrap\components\collapse\collapse.directive.ts, you guys have implemented the animation transition but commented them all out because of the following ng issue.

however, the issue 5984 has been closed in June 2016, can you guys advise when the animation will be enabled for ng2-bootstrap please?

// fix: replace with // '@angular/animate'; // when https://github.com/angular/angular/issues/5984 will be fixed

qjnz avatar Aug 14 '16 22:08 qjnz

+1 Animations are quintessential for something like Accordion.

raghavan85 avatar Sep 08 '16 00:09 raghavan85

Any updates on this?

wolfgangmeyers avatar Sep 30 '16 17:09 wolfgangmeyers

ok, with angular2 2.1 animations became a thing, so they will be added soon

valorkin avatar Oct 13 '16 20:10 valorkin

I needed accordion animations for a project so I made some very specific tweaks that work for my use-case. If anyone is interested you can check out: https://github.com/fareesh/ng2-bootstrap/commit/701af877bcc85f90eb21e6896cbdbfbff922393f

Would also be happy to make the necessary changes to make this usable in a generic case if someone can point me in the right direction.

fareesh avatar Oct 19 '16 17:10 fareesh

Hope the animations are coming soon, it's definitely a must.

Scipionh avatar Oct 27 '16 12:10 Scipionh

Any solutions??

zmnv avatar Jan 27 '17 06:01 zmnv

I can add almost all animations, but I will have to drop IE9 support because they simply doesn't work there plus at the moment it is hard to configure them

valorkin avatar Jan 27 '17 07:01 valorkin

@valorkin да это какой-то беспредел вообще. юзаю ангуляр 2 юниверсал, там мне админ говорит мол используй версию ng2-bootstrap 1.1.16. Потому что jQuery там (в юниверсале) работает через задницу, он работает, но в компонентах другие плагины типа owl.carousel2 отрубаются.

думал хоть это заработает. заработало. перелопатил css этот, зачем вообще использовать display, когда при разных значениях никакая анимация не работает. отрубаешь дисплей, меняешь на height: 0 (auto) и т.д. и все работает. Уже третьи сутки сижу потею как черт))

И то, если css правишь, то работает только opacity.

zmnv avatar Jan 27 '17 07:01 zmnv

Hi,

Any news / solution on this issue ?

k20human avatar Mar 01 '17 09:03 k20human

@k20human seems in ng v4+ animations will come as needed ;)

valorkin avatar Mar 01 '17 09:03 valorkin

@k20human just edit css files. The problem in 'display: block'. Delete it or replace to another style, besauce 'transitions' doesnt work with display: block in that case.

It helps for me. But after that i tryed SWIPER and its awesome

zmnv avatar Mar 01 '17 09:03 zmnv

Finally i use animate.css and use collapsed and expanded method in my component to add or remove class (for now)

public collapsed(event:any):void {
        this.render.setElementClass(event._el.nativeElement, 'slideInDown', false);
        this.render.setElementClass(event._el.nativeElement, 'slideOutDown', true);
    }

    public expanded(event:any):void {
        this.render.setElementClass(event._el.nativeElement, 'slideOutDown', false);
        this.render.setElementClass(event._el.nativeElement, 'slideInDown', true);
    }

k20human avatar Mar 01 '17 10:03 k20human

Biggest issue with animation at the moment, that directives doesn't support animation :(

valorkin avatar Mar 01 '17 11:03 valorkin

It's kinda blocker

valorkin avatar Mar 01 '17 11:03 valorkin

Has improved this situation with angular 4?

JetpackDuba avatar Mar 27 '17 22:03 JetpackDuba

+1

judsonmusic avatar Apr 04 '17 23:04 judsonmusic

+1

kaweski avatar Apr 18 '17 17:04 kaweski

4.1 promises to bring required features, but we will see

valorkin avatar Apr 18 '17 18:04 valorkin

Angular 4.1 is out! Does it bring the required features @valorkin ?

JetpackDuba avatar May 03 '17 09:05 JetpackDuba

@aeab13 issue to track angular progress https://github.com/angular/angular/issues/9947 I am actually a bit tired of waiting, so most probably I will provide some workaround

valorkin avatar May 03 '17 11:05 valorkin

News about this? I'm using Collpase directive on navbar menu (on small screens) but the animation does not work

@k20human I've tried your solution but it animates only the link, the background still appears instantly.

michelebombardi avatar May 25 '17 08:05 michelebombardi

any updates?

xjben avatar Jun 12 '17 13:06 xjben

in angular v4.2 added AnimationBuilder so... ;) in nearest time I will be adding animation to all existing components

valorkin avatar Jun 19 '17 11:06 valorkin

@valorkin now that you're adding animations to all components it would be really useful to be able to disable or enable programmatically.

danielGz avatar Jun 28 '17 23:06 danielGz

Animation without options to disable it will not be deployed

valorkin avatar Jun 29 '17 08:06 valorkin

Is there any progress on this yet? I'm looking forward to it. 👍

huyqut avatar Jul 08 '17 08:07 huyqut

I've been surprised by the lack of UI libraries available for Angular 2, even now 10 months after its official release! Material 2 is still in beta. Ng-bootstrap is still in alpha (and requires Bootstrap 4 which is in alpha). I've seen PrimeNG and MDBootstrap, but neither of those seem right for my needs. So thank you for working in this space!

Animation support is the last piece my team at work needs to adopt this library and start migrating from AngularJS. I'm looking forward to it!

ersimont avatar Jul 15 '17 14:07 ersimont