ngx-bootstrap icon indicating copy to clipboard operation
ngx-bootstrap copied to clipboard

Add support for Angular v20 #

Open markuspalme opened this issue 7 months ago • 3 comments

Builds using Angular 20 fail with errors such as this one:

✘ [ERROR] TS7016: Could not find a declaration file for module 'ngx-bootstrap/component-loader'. '/Users/markus/someapp/node_modules/ngx-bootstrap/component-loader/fesm2022/ngx-bootstrap-component-loader.mjs' implicitly has an 'any' type.
  If the 'ngx-bootstrap' package actually exposes this module, try adding a new declaration (.d.ts) file containing `declare module 'ngx-bootstrap/component-loader';` [plugin angular-compiler]

    node_modules/ngx-bootstrap/datepicker/bs-datepicker.component.d.ts:2:39:
      2 │ ...t { ComponentLoaderFactory } from 'ngx-bootstrap/component-loader';

It seems that this library must support Angular 20 explicitly.

Surprised to see that there is no such issue already, usually they are created some minutes after an Angular release :)

markuspalme avatar Jun 02 '25 18:06 markuspalme

I think we need to wait for a new non-beta/non-canary version of Nx as the current stable version requires Angular 19: https://github.com/nrwl/nx/blob/21.1.3/packages/angular/package.json#L70-L73

See: https://nx.dev/technologies/angular/recipes/angular-nx-version-matrix#nx-and-angular-version-compatibility-matrix

v20 support is added in 21.2.0 which only has these published versions as of now:

'21.2.0-beta.1',
'21.2.0-beta.2',
'21.2.0-canary.20250521-a52a435',
'21.2.0-canary.20250522-7e0719c',
'21.2.0-canary.20250523-560a53e',
'21.2.0-canary.20250524-e2b3aca',
'21.2.0-canary.20250527-4a94841',
'21.2.0-canary.20250528-2572455',
'21.2.0-canary.20250529-c8a6ffb',
'21.2.0-canary.20250530-b51676a',
'21.2.0-canary.20250603-88c5196',
'21.2.0-canary.20250604-283ec76',
'21.2.0-canary.20250605-5ffd82e',
'21.2.0-canary.20250606-c43d2f2'

dezsiszabi avatar Jun 08 '25 15:06 dezsiszabi

Nx 21.2.0 released 12. june. If that was the blocking issue then it should be green light now, right? :)

xkrillex avatar Jun 17 '25 06:06 xkrillex

Nx 21.2.0 released 12. june. If that was the blocking issue then it should be green light now, right? :)

I did open a PR: #6757

dezsiszabi avatar Jun 17 '25 07:06 dezsiszabi

Sooo, code is ready, PR is there.... any chance to roll it forward soon?

vladt22 avatar Jun 25 '25 12:06 vladt22

Any news on when #6757 will be merged?

Brown-Dan avatar Jun 25 '25 12:06 Brown-Dan

Let's do it!

songokudbz avatar Jul 03 '25 09:07 songokudbz

Really looking forward to this merge! We already would need it urgently. What is the plan for the rollout?

ltdatea avatar Jul 03 '25 09:07 ltdatea

Your automatic tests are failing, what's going on there? Doesn't seem like "just needs releasing" as an outsider who wishes to upgrade an angular applications which has angular-specific vulnerabilites that are fixed by the upgrade.

d4yvie avatar Jul 07 '25 07:07 d4yvie

It’s fine, it is not an actual issue with the unit tests. We just need one of the maintainers to merge it please…

Brown-Dan avatar Jul 07 '25 11:07 Brown-Dan

It has been merged, now we need to wait for the actual release.

songokudbz avatar Jul 10 '25 07:07 songokudbz

I'm curious - is this project being abandoned? Seems like there is no one to "click release button" anymore. If so - just please announce it so that developers should start looking for alternatives.

vladt22 avatar Jul 11 '25 13:07 vladt22

@lexasq

xkrillex avatar Jul 14 '25 05:07 xkrillex

@xkrillex I've already fully tested PR and working on release. Unfortunatelly I'm only able to approve and merge other PRs, but not my own, and for mine I got to get @valorkin and well it's not an easy task. Current issue that I forgot about NX cloud configuration updates and it failed release so I got to wait for approve on that fix, that will unlock release.

lexasq avatar Jul 14 '25 07:07 lexasq

Thank you for update! We all understand that this is open source project and there is no obligation to anyone. But since this is very popular and important package would be nice to have some backups... Anyways - standing by!

vladt22 avatar Jul 14 '25 16:07 vladt22

Somebody has a fork with version compatible with angular 20 published in npmjs?

alenap93 avatar Jul 15 '25 10:07 alenap93

Hi @lexasq, the release tag seems to have been released, but it isn't available on npmjs.com

rohanahata avatar Jul 16 '25 06:07 rohanahata

I found a next version 20 on npmjs https://www.npmjs.com/package/ngx-bootstrap/v/20.0.0

alenap93 avatar Jul 17 '25 19:07 alenap93

I found a next version 20 on npmjs https://www.npmjs.com/package/ngx-bootstrap/v/20.0.0

Should I use next version in production or not ?

frenzymind avatar Jul 21 '25 04:07 frenzymind

Should I use next version in production or not ?

At your own risk. There is no updates in documentation nor in changelog since v18.

amelnikoff avatar Jul 21 '25 04:07 amelnikoff

Even though I was the one who did the Angular 20 upgrade PR, the way this release was/is handled left a sour taste in my mouth.

Now, because of this, I basically removed ngx-bootstrap from my project at work... I wrote my own popover and tooltip components over the weekend, changed all the collapse, alert and modal usages I had to alternatives (vanilla bootstrap or @angular/cdk approaches).

To me, this project unfortunately feels half abandoned.

dezsiszabi avatar Jul 21 '25 04:07 dezsiszabi

To me, this project unfortunately feels half abandoned.

@lexasq, @valorkin, can you please comment on the state of ngx-bootstrap? Following the discussion here and the completely understandable comment of @dezsiszabi, it would be good to get a concrete update on the project's status.

costas80 avatar Jul 27 '25 12:07 costas80

This has become unacceptable 👎 Time to switch to ng-bootstrap

alexanderzeillinger avatar Jul 28 '25 13:07 alexanderzeillinger

I'm copying the comment of @lexasq in https://github.com/valor-software/ngx-bootstrap/pull/6762#issuecomment-3131384443, since it seems relevant here as well;

There's already a next release that can be used, this documentation stall was stopping me from finalizing checks and release it properly with promote to latest, because I also got to build and check how it all ties up on our website as well.

WikiRik avatar Jul 29 '25 14:07 WikiRik

Release of Angular v20 support is finalize, sorry for the inconvenience during the process.

lexasq avatar Jul 29 '25 19:07 lexasq