ngx-bootstrap icon indicating copy to clipboard operation
ngx-bootstrap copied to clipboard

Modal: closeinterceptor not working on versions from 10.0.0 to 11.0.2

Open amoroso81 opened this issue 1 year ago • 2 comments

Bug description: The closeinterceptor function related to modal dialogs is not being called using version 11.0.2. An example could be found on your demo page at the section Close interceptor: clicking the Close button should open a new confirm dialog, but that does not appear and the previous modal dialog gets closed; choosing version 9.0.0 the confim dialog appears and everything works.

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 11 Angular: 16 Bootstrap: 5

amoroso81 avatar Sep 14 '23 09:09 amoroso81

I did some debug about this problem and found that it was introduced in version 10.0.0 by this commit ( https://github.com/valor-software/ngx-bootstrap/commit/8f0807eaaa089e46df381a009781427300eaa5e0 ). Now it seems that none calls the method modalContainerRef.instance?.hide() which is deputed to call the closeInterceptor method. Could someone please look further at this bug and provide a fix? Thanks in advance.

amoroso81 avatar Sep 25 '23 10:09 amoroso81

Is anyone looking into this? We have just finished updating to Angular 17 and all the third libraries and it would be a massive pain if we had to downgrade... This is causing several bugs in our app.

renaldas-kerpe-arria avatar May 15 '24 17:05 renaldas-kerpe-arria