fix(datepicker): fixed timepicker updates in datepicker with timepicker

[SvetlanaMuravlova]

fix(datepicker): fixed timepicker updates in datepicker with timepicker closes #6433

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit 1970114):

https://ngx-bootstrap-demo--pr6457-fix-datepicker-with-en4tukef.web.app

_{(expires Mon, 02 May 2022 14:31:47 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[cypress[bot]]

---

Test summary

797 • 35 • 14 • 0

---

Run details

Project	ngx-bootstrap
Status	Failed
Commit	c34ee21cc7 ℹ️
Started	Nov 30, 2022 1:53 PM
Ended	Nov 30, 2022 2:24 PM
Duration	30:41 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 100

View run in Cypress Dashboard ➡️

---

Failures

	datepicker/locales_spec.ts		2
1	Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2	Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
	typeahead_page_spec.ts		1
1	Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
	modals_service_page_spec.ts		7
1	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal
2	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal
3	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
4	Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
5	Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
6	Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
7	Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
This comment includes only the first 10 test failures. See all 35 failures in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[wedgberto]

I checked the demo site and can confirm that the daterangepicker does now emit time changes, however the picker has become painful to use because it is not possible to select a complete datetime range without the picker closing down multiple times!

[SvetlanaMuravlova]

I checked the demo site and can confirm that the daterangepicker does now emit time changes, however the picker has become painful to use because it is not possible to select a complete datetime range without the picker closing down multiple times!

I checked your issue, and i can confirm it. But as i can see it is default behavior of datepicker and daterangepicker, so you can open a new issue as enhancement for it and we will discuss it.

[Tea-Ice]

@valorkin Any chance of merging this in?

[github-actions[bot]]

Visit the preview URL for this PR (updated for commit 2612c8f):

https://ngx-bootstrap-demo--pr6457-fix-datepicker-with-tqtwd110.web.app

_{(expires Wed, 07 Dec 2022 13:52:09 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07}

[codecov[bot]]

Codecov Report

Merging #6457 (c34ee21) into development (40c181c) will increase coverage by 0.89%. The diff coverage is 86.84%.

:exclamation: Current head c34ee21 differs from pull request most recent head 2612c8f. Consider uploading reports for the commit 2612c8f to get more accurate results

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #6457      +/-   ##
===============================================
+ Coverage        75.84%   76.73%   +0.89%     
===============================================
  Files              315      315              
  Lines            10642    10613      -29     
  Branches          2935     2923      -12     
===============================================
+ Hits              8071     8144      +73     
+ Misses            2570     2468     -102     
  Partials             1        1              

Impacted Files	Coverage Δ
src/accordion/accordion-group.component.ts	100.00% <ø> (+6.66%)	:arrow_up:
src/alert/alert.module.ts	100.00% <ø> (ø)
src/carousel/carousel.component.html	100.00% <ø> (ø)
src/collapse/collapse.directive.ts	73.03% <0.00%> (ø)
src/datepicker/bs-datepicker.module.ts	100.00% <ø> (ø)
src/dropdown/bs-dropdown-container.component.ts	50.00% <0.00%> (-1.43%)	:arrow_down:
src/dropdown/bs-dropdown.module.ts	100.00% <ø> (ø)
src/modal/modal-container.component.ts	44.15% <0.00%> (+6.65%)	:arrow_up:
src/modal/modal-options.class.ts	100.00% <ø> (ø)
src/modal/modal.module.ts	85.71% <ø> (ø)
... and 31 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f0807e...2612c8f. Read the comment docs.

[queejie]

It seems like the bug that I'm experiencing is identified here, but the fix was not incorporated? You can't scroll the time without the dialog closing, and if you pick a date before setting the time, it closes before you can do anything else.

[SvetlanaMuravlova]

It seems like the bug that I'm experiencing is identified here, but the fix was not incorporated? You can't scroll the time without the dialog closing, and if you pick a date before setting the time, it closes before you can do anything else.

yeah, it is, but it could be resolved in another pr, cause it is the native behaviour of element

[SvetlanaMuravlova]

it was resolved in previous pr and as result it is fixed since version 9.0.0