ngx-bootstrap icon indicating copy to clipboard operation
ngx-bootstrap copied to clipboard

fix(Typeahead) highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags

Open UdayAppam opened this issue 3 years ago • 5 comments

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • [ ] read and followed the CONTRIBUTING.md guide.
  • [ ] built and tested the changes locally.
  • [ ] added/updated tests.
  • [ ] added/updated API documentation.
  • [ ] added/updated demos.

UdayAppam avatar Feb 17 '22 08:02 UdayAppam

https://github.com/valor-software/ngx-bootstrap/issues/4350 Could you please review and if any suggestions open to discuss

UdayAppam avatar Feb 17 '22 08:02 UdayAppam

Codecov Report

Merging #6434 (f106c2b) into development (6be9fc4) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head f106c2b differs from pull request most recent head 2c54fb0. Consider uploading reports for the commit 2c54fb0 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6434      +/-   ##
===============================================
- Coverage        75.87%   75.86%   -0.02%     
===============================================
  Files              315      315              
  Lines            10642    10644       +2     
  Branches          2935     2936       +1     
===============================================
  Hits              8075     8075              
- Misses            2566     2568       +2     
  Partials             1        1              
Impacted Files Coverage Δ
src/typeahead/typeahead-container.component.ts 80.95% <100.00%> (+0.20%) :arrow_up:
src/chronos/i18n/sk.ts 85.00% <0.00%> (-2.50%) :arrow_down:
src/chronos/i18n/cs.ts 87.36% <0.00%> (-2.11%) :arrow_down:
src/chronos/i18n/pl.ts 85.24% <0.00%> (ø)
src/chronos/i18n/uk.ts 90.62% <0.00%> (+3.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6be9fc4...2c54fb0. Read the comment docs.

codecov[bot] avatar Feb 17 '22 08:02 codecov[bot]



Test summary

799 33 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 30347bc90f ℹ️
Started Mar 23, 2022 5:30 AM
Ended Mar 23, 2022 6:06 AM
Duration 35:52 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 33 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Feb 17 '22 08:02 cypress[bot]

Hi @valorkin Could you please review these changes.

UdayAppam avatar Feb 18 '22 08:02 UdayAppam

Is there any update to this issue? Can happily offer a reward to the person who gets this merged.

matthewfedak avatar Oct 31 '22 12:10 matthewfedak