fix(Typeahead) highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
- [ ] read and followed the CONTRIBUTING.md guide.
- [ ] built and tested the changes locally.
- [ ] added/updated tests.
- [ ] added/updated API documentation.
- [ ] added/updated demos.
https://github.com/valor-software/ngx-bootstrap/issues/4350 Could you please review and if any suggestions open to discuss
Codecov Report
Merging #6434 (f106c2b) into development (6be9fc4) will decrease coverage by
0.01%. The diff coverage is100.00%.
:exclamation: Current head f106c2b differs from pull request most recent head 2c54fb0. Consider uploading reports for the commit 2c54fb0 to get more accurate results
@@ Coverage Diff @@
## development #6434 +/- ##
===============================================
- Coverage 75.87% 75.86% -0.02%
===============================================
Files 315 315
Lines 10642 10644 +2
Branches 2935 2936 +1
===============================================
Hits 8075 8075
- Misses 2566 2568 +2
Partials 1 1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/typeahead/typeahead-container.component.ts | 80.95% <100.00%> (+0.20%) |
:arrow_up: |
| src/chronos/i18n/sk.ts | 85.00% <0.00%> (-2.50%) |
:arrow_down: |
| src/chronos/i18n/cs.ts | 87.36% <0.00%> (-2.11%) |
:arrow_down: |
| src/chronos/i18n/pl.ts | 85.24% <0.00%> (ø) |
|
| src/chronos/i18n/uk.ts | 90.62% <0.00%> (+3.12%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6be9fc4...2c54fb0. Read the comment docs.
Test summary
Run details
| Project | ngx-bootstrap |
| Status | Failed |
| Commit | 30347bc90f ℹ️ |
| Started | Mar 23, 2022 5:30 AM |
| Ended | Mar 23, 2022 6:06 AM |
| Duration | 35:52 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Electron 93 |
View run in Cypress Dashboard ➡️
Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Hi @valorkin Could you please review these changes.
Is there any update to this issue? Can happily offer a reward to the person who gets this merged.