ngx-bootstrap
ngx-bootstrap copied to clipboard
feat(tooltip, popover): add functionality, which hide tooltip & popover after delay (#5572)
closes #5572
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
- [x] read and followed the CONTRIBUTING.md guide.
- [x] built and tested the changes locally.
- [x] added/updated tests.
- [x] added/updated API documentation.
- [x] added/updated demos.
Codecov Report
Merging #5599 (e41dcf5) into development (6e200b5) will increase coverage by
73.83%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## development #5599 +/- ##
================================================
+ Coverage 0 73.83% +73.83%
================================================
Files 0 323 +323
Lines 0 11661 +11661
Branches 0 2490 +2490
================================================
+ Hits 0 8610 +8610
- Misses 0 1963 +1963
- Partials 0 1088 +1088
Impacted Files | Coverage Δ | |
---|---|---|
demo/src/ng-api-doc.ts | 100.00% <ø> (ø) |
|
src/popover/popover.config.ts | 76.47% <100.00%> (ø) |
|
src/popover/popover.directive.ts | 71.56% <100.00%> (ø) |
|
src/tooltip/tooltip.config.ts | 75.00% <100.00%> (ø) |
|
src/tooltip/tooltip.directive.ts | 67.94% <100.00%> (ø) |
|
src/chronos/create/from-string-and-array.ts | 95.83% <0.00%> (ø) |
|
src/datepicker/reducer/bs-datepicker.effects.ts | 75.55% <0.00%> (ø) |
|
src/timepicker/timepicker.component.ts | 92.16% <0.00%> (ø) |
|
src/pagination/pager.component.ts | 79.71% <0.00%> (ø) |
|
src/chronos/create/from-array.ts | 86.30% <0.00%> (ø) |
|
... and 318 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6e200b5...581cab6. Read the comment docs.
hey, @dmitry-zhemchugov , I will need your help with fixing my e2e tests later :)
Need fix regarding cooldown of tooltip @daniloff200
Project: ngx-bootstrap-demo Url: https://ngx-bootstrap-demo--pr-5599-pccirowb.web.app This link will expire at Thu 11 Mar 2021 07:40:19 AM GMT
Test summary
Run details
Project | ngx-bootstrap |
Status | Passed |
Commit | 6c923d468f ℹ️ |
Started | Feb 9, 2021 7:54 AM |
Ended | Feb 9, 2021 8:00 AM |
Duration | 06:48 💡 |
OS | Linux Ubuntu Linux - 16.04 |
Browser | Electron 61 ![]() |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
why this PR still open